Diff
Not logged in

Differences From:

File src/info.c part of check-in [bdac9f7238] - Fix a stupid bug of mine introduced in 3c9e5699ce. If the ZIP archive's name is composed, the actual project's name should be chosen instead of a fix fossil. by hintze on 2008-08-14 04:52:30. [view]

To:

File src/info.c part of check-in [589687d783] - Fix bug c858c4178b - at three places, the original checkin comment was taken from the repository. Only if there was no original checkin comment, the edited comment (ecomment) was fetched.

That logic seem wrong. As at all other cases, first the ecommend was fetched and only when that failed, the original comment was taken, I corrected the three places in code accordingly.

by cle on 2008-08-14 16:15:17. [view]

@@ -117,9 +117,9 @@
   int cnt = 0;
   db_prepare(&q,
     "SELECT plink.cid, blob.uuid, datetime(plink.mtime, 'localtime'),"
     "       coalesce(event.euser,event.user),"
-    "       coalesce(event.comment,event.ecomment)"
+    "       coalesce(event.ecomment,event.comment)"
     "  FROM plink, blob, event"
     " WHERE plink.pid=%d"
     "   AND blob.rid=plink.cid"
     "   AND event.objid=plink.cid"
@@ -169,9 +169,9 @@
   int cnt = 0;
   db_prepare(&q,
     "SELECT plink.pid, blob.uuid, datetime(event.mtime, 'localtime'),"
     "       coalesce(event.euser,event.user),"
-    "       coalesce(event.comment,event.ecomment)"
+    "       coalesce(event.ecomment,event.comment)"
     "  FROM plink, blob, event"
     " WHERE plink.cid=%d"
     "   AND blob.rid=plink.pid"
     "   AND event.objid=plink.pid"
@@ -660,9 +660,9 @@
   int cnt = 0;
   int nWiki = 0;
   db_prepare(&q,
     "SELECT filename.name, datetime(event.mtime), substr(a.uuid,1,10),"
-    "       coalesce(event.comment,event.ecomment),"
+    "       coalesce(event.ecomment,event.comment),"
     "       coalesce(event.euser,event.user),"
     "       b.uuid"
     "  FROM mlink, filename, event, blob a, blob b"
     " WHERE filename.fnid=mlink.fnid"