Check-in [fa643aa91d]
Not logged in
Overview

SHA1 Hash:fa643aa91d93c6c3ffeb44dd14e267db8c8139cf
Date: 2007-10-24 07:54:01
User: aku
Comment:Disabled check for control characters in the log message. Allowing this for the moment, lets see if we run into trouble later on. Further reworked the check of symbol names, disallow forward slashs only at end. Found legal tags containing forward slashs in the middle.
Timelines: ancestors | descendants | both | trunk
Other Links: files | ZIP archive | manifest

Tags And Properties
Changes
[hide diffs]

Modified tools/cvs2fossil/lib/rcsparser.tcl from [b3b8dd19e7] to [93e4a1e5a5].

@@ -76,11 +76,14 @@
     }
 
     proc Symbols {} {
 	RequiredLiteral symbols
 	while {[Ident -> symbol]} {
-	    if {![regexp {^\d*[^/,.:;@$]([^/,.:;@$]*\d*)*$} $symbol]} {
+	    if {
+		![regexp {^\d*[^,.:;@$]([^,.:;@$]*\d*)*$} $symbol] ||
+		[string match */ $symbol]
+	    } {
 		Rewind
 		Bad {symbol name}
 	    }
 	    RequiredNumber -> rev
 	    Call deftag $symbol $rev
@@ -220,12 +223,12 @@
     proc DeltaTexts {} {
 	while {[OptionalNumber -> rev]} {
 	    RequiredLiteral log
 	    RequiredString      -> cmsg
 	    if {[regexp {[\000-\010\013\014\016-\037]} $cmsg]} {
-		Rewind
-		Bad "log message for $rev contains at least one control character"
+		#Rewind
+		#Bad "log message for $rev contains at least one control character"
 	    }
 
 	    RequiredLiteral text
 	    RequiredStringRange -> delta
 	    Call extend $rev $cmsg $delta