Ticket change
[
b56d4bcf6e]
(rid 3615) by
drh on
2008-10-26 02:29:47:
- Change priority to "Immediate"
- Change resolution to "Open"
- Change status to "Fixed"
Ticket change
[
aaf3bac075]
(rid 3555) by
anonymous on
2008-10-24 06:42:14:
- Change comment to "'blob_add_cr()' has buffer overrun if it requires to call 'blob_resize()'
(declared in "blob.c") 'blob_add_cr()' increase 'Blob#nUsed' if Blob includes '\n'. and 'blob_resize()' update it, too. then it makes buffer overrun.
here is my replacement
<verbatim>void blob_add_cr(Blob *p){
char *z = p->aData;
int j = p->nUsed;
int i, n;
for(i=n=0; i<j; i++){
if( z[i]=='\n' ) n++;
}
j += n;
if( j>=p->nAlloc ){
blob_resize(p, j);
z = p->aData;
}
p->nUsed = j;
z[j] = 0;
while( j>i ){
if( (z[--j] = z[--i]) =='\n' ){
z[--j] = '\r';
}
}
}</verbatim>"
- Change foundin to "a1f727be9d"
- Change private_contact to "073f0e6044dde71b455edbcf5fe3e9aafd90cec8"
- Change severity to "Minor"
- Change status to "Open"
- Change title to "win32 fossil commit stops if many files added or edited."
- Change type to "Code_Defect"