- Appended to comment:
drh added on 2009-06-20 23:07:07:
Change implemented by check-in deb6f2af4fa9302f2ace7db76be68446eafdf571 - Change resolution to "Fixed"
- Change status to "Fixed"
- Change comment to "Zip files downloaded from Fossil can not be opened with the 7-Zip program. After some poking in the Zip File Format Specification, I found that the "disk number start" field in the File Header of the Central directory structure was set to 1 instead off 0. The following patch solves this problem: <pre> --- Fossil-266b6127f6/src/zip.c 2009-06-20 11:06:00 +0000 +++ Fossil-266b6127f6-new/src/zip.c 2009-06-20 21:35:42 +0000 @@ -194,7 +194,7 @@ put16(&zBuf[28], nameLen); put16(&zBuf[30], 0); put16(&zBuf[32], 0); - put16(&zBuf[34], 1); + put16(&zBuf[34], 0); put16(&zBuf[36], 0); put32(&zBuf[38], ((unsigned)(0100000 | 0644))<<16); put32(&zBuf[42], iStart); </pre> <pre> -- Thomas Schnurrenberger </pre>"
- Change foundin to "266b6127f6"
- Change private_contact to "76518fb407f147a1d053c00b5b993281a339c0e3"
- Change severity to "Important"
- Change status to "Open"
- Change title to "7-Zip is unable to open Zip files generated by Fossil"
- Change type to "Code_Defect"