Artifact Content
Not logged in

Artifact eb6a9f18bf467e985c739809a791fe189ac7c9fe

Ticket change [eb6a9f18bf] - Open ticket c62fac40af: Edit CSS/HTML in Setup adds extra CR/LF, wrong http Content-length plus 1 other change by anonymous on 2008-11-19 23:52:05.

D 2008-11-19T23:52:05
J +comment \n\n<hr><i>anonymous\sadded\son\s2008-11-19\s23:52:05:</i><br>\nThanks\sfor\sthe\sfix,\sdrh.\s\r\n\r\n\s\s*\s\sBad\snews:\sI'm\safraid\sit\sdidn't\sreally\sfix\sit.\sThe\scontents\sof\sthe\sEditCSS\stextbox\sstill\shave\sextra\s\\r\s,\sso\sline\sspacing\sincreases\sby\sone\safter\severy\sedit.\r\n\r\n\s\s*\s\sGood\snews:\sstdout\scan\sbe\smade\sbinary\swith\ssetmode(),\swhich\sprevents\sthe\s\\n\sto\s\\r\\n\stranslation.\r\n\r\n<verbatim>\r\nPatches\sfor\smain.c:\r\n\r\n{line\s30,\sin\sheader\sincludes}\r\n=\s#include\s<time.h>\r\n+\s#ifdef\s__MINGW32__\r\n+\s/*\sDefine\sfile\smode\sconstants\s*/\r\n+\s#include\s<fcntl.h>\r\n+\s#endif\r\n\r\n{line\s615,\sin\scmd_cgi()\s}\r\n=\s\sg.httpOut\s=\sstdout;\r\n+\s#ifdef\s__MINGW32__\r\n+\s\s\s/*\sprevent\s\\n\sto\s\\r\s\\n\stranslation\son\sWindows\s*/\r\n+\s\s\ssetmode(\s_fileno(g.httpOut),\s_O_BINARY\s);\r\n+\s#endif\r\n\r\nThe\sworkaround\sin\scgi.c,\sfunction\scgi_reply()\s,\sis\sno\slonger\snecessary;\sthe\scontent-length\sheader\sis\svalid.\r\n</verbatim>\r\n\r\nFull\sdiffs\swill\sbe\sposted\son\sthe\sfossil-users\smailing\slist.\r\n\r\nEnvironment:\sWindows\sVista,\sApache\shttpd\s2.2.9,\smod_cgi,\sfossil\s[63886daad8]\s2008-11-18\s15:33:25\sUTC\r\n\r\n
J status Open
K c62fac40af0860d28ad287cb3f203581e00fc9c8
U anonymous
Z 294f26476016fb7e08978e561a315b29