Artifact 97a208b57e4a48767650f24235a98fa2e9593efc

Ticket change [97a208b57e] - Ticket 66de526498 tickets; new report format; Syntax error: no such function; functions user(), aux(), wiki()... status still Open with 1 other change by anonymous on 2009-11-28 21:35:42.

D 2009-11-28T21:35:42
J +comment \n\n<hr><i>anonymous\sclaiming\sto\sbe\sbtheado\sadded\son\s2009-11-28\s21:35:42:</i><br>\nI\salso\snoticed\show\sthese\ssql\sfunctions\sare\smissing\sfrom\sthe\scurrent\sfossil\simplementation\sand\sI\stook\sa\sstab\sat\sporting\ssome\sof\sit\sover\sfrom\scvstrac.\r\n\r\nBoth\suser()\sand\scgi()\sboth\swere\sstraightforward.\r\n\r\nThe\scode\sfor\saux()\sand\soption()\sis\smore\scomplicated.\s\sMaybe\sit\swill\salso\sbe\sstraightforward,\sbut\sI\shaven't\slooked\sclose\senough\syet.\r\n\r\nI\slooked\sat\sthe\swiki()\simplementation\sin\scvstrac\sand\sthe\sfunctionality\sdoesn't\sreally\sseem\slike\sa\sgood\sfit\sfor\sa\ssql\sfunction.\s\sThe\sfunction\sonly\sprefixes\sthe\scell\svalues\swith\sa\sspecial\sstring\sthat\slater\striggers\swiki\sconversion\s(and\sbypasses\shtml\sescaping\sas\sfor\sother\snormal\scolumns).\s\sWith\sthis\sbehavior,\sI\sdon't\sthink\s'wiki()'\scan\sbe\scombined\swith\sother\ssqlite\soperations\svery\swell.\s\sIf\sthe\suser\swants\sto\sperform\sadditional\smodification\sto\sthe\soutput\sof\s'wiki()'\swith\sanother\ssql\sfunction,\sthen\sthey\swould\slikely\sbe\ssurprised\sto\sfind\sat\sthe\ssql\slevel\sthat\sthe\soutput\sof\sthat\sfunction\sis\snot\sthe\swiki\sconverted\stext.\s\sI\sdon't\ssee\sa\suse\scase\sfor\sdoing\sthat,\sbut\sit\smakes\sit\sseem\sto\sme\slike\sit\sis\sa\sbad\sfit\sfor\sa\ssql\sfunction.\r\n\r\nSo\sI\stook\sthe\sapproach\sof\sadding\sa\snew\sspecial\scolumn\sname\sprefix.\s\sIf\sthe\scolumn\sname\sis\sprefixed\swith\sthe\sstring\s'_wiki_'\sthen\sthe\scells\sin\sthat\scolumn\swill\sbe\swiki\sconverted\sand\sthe\s'_wiki_'\sprefix\swill\sbe\sremoved\sfrom\sthe\scolumn\sname.\s\sAll\sother\scolumn\snames\sprefixed\swith\s'_'\s\swill\strigger\sthe\s"new\srow"\sfunctionality\sas\sbefore.\r\n\r\nWhat\sdo\syou\sthink\sof\sthis\sapproach?\r\n\r\nI\shave\sthese\schanges\schecked\sinto\sa\slocal\sclone\sof\sthe\sfossil\srepository.\s\sI\screated\smy\sown\sbranch\sfor\sthese\schanges,\sbut\sthen\saccidentally\schecked\sthe\schanges\sinto\sthe\strunk\s(I'm\snot\swell\sversed\swith\sthe\sVC\sside\sof\sfossil\syet).\s\sI'm\snot\ssure\syet\show\sto\sfix\sthat.\s\sI\sguess\sI\scan\sjust\sstart\sover\swith\sa\sfresh\sfossil\sclone\sand\smake\sthe\scheckins\sagain.\r\n\r\nAre\syou\sinterested\sin\shaving\sthese\schanges\spushed\sinto\sthe\sfossil\srepository?
K 66de5264986d6cb2633ddf10d9dfbe264a7b6406
U anonymous
Z 13bff2e71562e3727367487d7574ccc7