View Ticket
Not logged in
Ticket UUID: f083ffffc655f777c5897ccfd5197fabe1143bb2
Title: Inconsistent display of closed tickets id's as striked out links in timeline
Status: Closed Type: Code_Defect
Severity: Minor Priority:
Subsystem: Resolution: Not_A_Bug
Last Modified: 2008-11-30 19:32:29
Version Found In: [c12e5b102e] 2008-11-27 13:50:41
Description & Comments:
While checking on timeline page, I see on my cloned copy of fossil repository just some of closed tickets id's striked.
In my local copy, I see both lines with striked links to closed tickets (1dd22c3a2b and 1dd22c3a2b):

2008-11-27
23:37:45 * 74747d3dcf Closed ticket 1dd22c3a2b
23:30:16 * b4402cf8af Ticket 1dd22c3a2b

The next striked one on my copy is(with striked link 807ca32b80):

2008-11-25
18:42:55 * 3f824675cd Closed ticket 807ca32b80

On the contrary, on fossil web page I see as striked many more links to already closed tickets.
First one is already the line:

2008-11-27
13:51:22 * 4cbd3b67c9 Fixed ticket 66cbcd56a2


eric added on 2008-11-28 07:19:56:
But 66cbcd56a2 is fixed, not closed (at this time) - this will be due to a difference in the ticket config (third item in Setup->Tickets->Timeline).


anonymous claiming to be kkinnell added on 2008-11-28 15:32:04:
Wouldn't this have more to do with when the local repository was synced with the main repo? If you pull/update from the main repository to the local, and look at the timelines right then, they should be a 99% match. (There's always a chance someone closed a ticket while you were doing your "pull".)


anonymous added on 2008-11-28 17:58:17:
I was describing situation with freshly updated repo. When I can, I will check if it is related to changes in Setup->Tickets->Timeline menu as suggested. But I guess, there are default values set.


eric added on 2008-11-28 19:36:37:

$ fossil version
This is fossil version f84bfc31bf 2008-11-27 02:30:29 UTC
$ fossil pull  http://www.fossil-scm.org/fossil/
...

At this point, I have looked at the timelines from my clone repository and www.fossil-scm.org side by side in the browser and seen exactly the difference described.

eric@tasso:~/devel/fossil$ fossil export ticket emjtkt
eric@tasso:~/devel/fossil$ fossil config pull ticket http://www.fossil-scm.org/fossil/
...
$ fossil config export ticket drhtkt

On refreshing pages in the browser, they now look identical.

Looking at the export files, there are lots of differences, but in particular, I had

REPLACE INTO config VALUES('ticket-closed-expr','status=''Closed''');

while the pulled config has

REPLACE INTO config VALUES('ticket-closed-expr','status=''Closed'' OR status=''Fixed''');

The former is specified as the default in tktsetup.c and wikiformat.c, so I feel quite justified closing this as "Not A Bug".


anonymous added on 2008-11-30 19:32:29:
Thank you for the insight into this configuration issue.
After updating Setup->Tickets->Timeline option Ticket Closed to value:
status='Closed' OR status='Fixed'
local timeline now looks exactly as on fossil web site.

Just a remark, while I pulled config with:
fossil config pull ticket http://www.fossil-scm.org/fossil/

and compared exported ticket export files from original and updated repository, they looked exactly the same (beside datetime line) and did not contain:

REPLACE INTO config VALUES('ticket-closed-expr'...

line at all.