Ticket UUID: |
e28adcd72503a24599f84e378c5d8c6bb28a7758
|
Title: |
"zip.c" has two minor bugs.
|
Status: |
Fixed
|
Type: |
Code_Defect
|
Severity: |
Cosmetic
|
Priority: |
|
Subsystem: |
|
Resolution: |
Fixed
|
Last Modified: |
2008-11-27 13:26:43
|
Version Found In: |
a8c3a7ea92 2008-11-22T19:32:44
|
Description & Comments: |
"zip.c" has two minor bugs.
- 'dosTime' time stamp has only 5 bits for 'seconds' field. so it requires devide by 2.
(in function 'zip_set_timedate_from_str()')
- dosTime = (H<<11) + (M<<5) + S;
+ dosTime = (H<<11) + (M<<5) + (S>>1);
- function 'baseline_zip_page()' (as 'WEBPAGE: zip') finally calls 'cgi_reply()', but it not required.
because 'cgi_reply()' calls by caller (main.c / process_one_web_page()) after this function returned.
current version try to send '.zip' file twice.
(almost http client checks 'Content-Length' header and shutdown themself first '.zip' file received.
so this bug did not generate twice traffic.)
drh added on 2008-11-27 13:26:43:
Fixed by check-in 39bbc6010e
|