Changes to ticket 41bb23e650

By anonymous on 2008-10-24 06:42:14. See also: artifact content, and ticket history

1. Change comment to "'blob_add_cr()' has buffer overrun if it requires to call 'blob_resize()' (declared in "blob.c") 'blob_add_cr()' increase 'Blob#nUsed' if Blob includes '\n'. and 'blob_resize()' update it, too. then it makes buffer overrun. here is my replacement <verbatim>void blob_add_cr(Blob *p){ char *z = p->aData; int j = p->nUsed; int i, n; for(i=n=0; i<j; i++){ if( z[i]=='\n' ) n++; } j += n; if( j>=p->nAlloc ){ blob_resize(p, j); z = p->aData; } p->nUsed = j; z[j] = 0; while( j>i ){ if( (z[--j] = z[--i]) =='\n' ){ z[--j] = '\r'; } } }</verbatim>"
2. Change foundin to "a1f727be9d"
3. Change private_contact to "073f0e6044dde71b455edbcf5fe3e9aafd90cec8"
4. Change severity to "Minor"
5. Change status to "Open"
6. Change title to "win32 fossil commit stops if many files added or edited."
7. Change type to "Code_Defect"