Changes to ticket 500a94b9e5

By kkinnell on 2008-12-27 18:02:40. See also: artifact content, and ticket history

1. Appended to comment:

   ---

   kkinnell added on 2008-12-27 18:02:40:
   I see the convenience of this, but it's more a matter of developer discipline than anything, isn't it? I don't think you can actually remove the need for review of the tickets affected by a commit. Suppose you make a change that affects two tickets, then back it out and commit a change that affects only one of them? At that point, you'd have a ticket with an "affected by commit" comment and a second "affected by commit" comment, with no effective change in the code. You surely would not want to back out any other changes to the baseline, so it wouldn't by very safe to back out ticket wiki changes—you could be "backing out" to a new leaf, instead of the baseline you had at the first commit.

   It would be far better to document the "badness" of the original change in the code than to hide it in a commit comment (which may not even mention it) I would think. This sort of thing may happen more than one would guess, especially if the code is under heavy development.

   If this feature were implemented, it would have to be a toggle. It would be better to make this a Th1 "plugin" and share it around.

2. Change foundin to "all"
3. Change resolution to "Open"
4. Change status to "Review"
5. Change title to "link checkins and relevant tickets"