Differences From:

File tools/cvs2fossil/lib/c2f_prev.tcl part of check-in [fbfb531868] - Bugfix in ValidateFragments, tweaked comment a bit, bugfix in SQL, reordered tables in the successor/predecessor queries a bit to show the actual progression of their use. by aku on 2007-12-02 03:46:33. [view]

To:

File tools/cvs2fossil/lib/c2f_prev.tcl part of check-in [ac02614803] - Deactivated caching of the nextmap/premap data, with the indices the retrieval seems to be fast enough to allow us to reduce mem consumption. Tweaked log output, and sql formatting. by aku on 2007-12-02 03:49:11. [view]

@@ -128,20 +128,22 @@
     }
 
     # item -> list (item)
     method nextmap {} {
-	if {[llength $mynextmap]} { return $mynextmap }
+	#if {[llength $mynextmap]} { return $mynextmap }
 	$mytypeobj successors tmp $myitems
-	set mynextmap [array get tmp]
-	return $mynextmap
+	return [array get tmp]
+	#set mynextmap [array get tmp]
+	#return $mynextmap
     }
 
     # item -> list (item)
     method premap {} {
-	if {[llength $mypremap]} { return $mypremap }
+	#if {[llength $mypremap]} { return $mypremap }
 	$mytypeobj predecessors tmp $myitems
-	set mypremap [array get tmp]
-	return $mypremap
+	return [array get tmp]
+	#set mypremap [array get tmp]
+	#return $mypremap
     }
 
     method breakinternaldependencies {} {
 
@@ -365,9 +367,9 @@
 	return
     }
 
     method loopcheck {} {
-	log write 7 csets {Checking [$self str] /[llength $myitems]}
+	log write 7 csets {Checking [$self str] for loops /[llength $myitems]}
 
 	if {![struct::set contains [$self successors] $self]} {
 	    return 0
 	}
@@ -738,16 +740,17 @@
     }
 
     # Print identifying data for a revision (project, file, dotted rev
     # number), for high verbosity log output.
+    # TODO: Replace with call to itemstr (list rev $id)
 
     proc PD {id} {
 	foreach {p f r} [state run {
 		SELECT P.name , F.name, R.rev
 		FROM revision R, file F, project P
 		WHERE R.rid = $id
-		AND   R.fid = F.fid
-		AND   F.pid = P.pid
+		AND   F.fid = R.fid
+		AND   P.pid = F.pid
 	}] break
 	return "'$p : $f/$r'"
     }