Diff
Not logged in

Differences From:

File tools/cvs2fossil/lib/c2f_prev.tcl part of check-in [c14e8f84cd] - Moved the integrity checks for split fragments into separate command. Reworked breaking of internal dependencies to contrain the length of the pending list. That part of the system is still a memory hog, especially for large changesets. Added notes about this and the successor retrieval being a bottleneck. by aku on 2007-11-30 06:50:47. [view]

To:

File tools/cvs2fossil/lib/c2f_prev.tcl part of check-in [0af7a3c8ac] - Easier name for self-referential changesets, loopcheck. Made conditional on option --loopcheck, default off, and avoided if the general checks on changesets report trouble. Reinstated the loop check in the cycle breaker core in simpler form, reusing the new command in the changeset class. by aku on 2007-11-30 06:57:19. [view]

@@ -364,9 +364,9 @@
 	set mychangesets [lreplace $mychangesets $pos $pos]
 	return
     }
 
-    method selfreferential {} {
+    method loopcheck {} {
 	log write 7 csets {Checking [$self str] /[llength $myitems]}
 
 	if {![struct::set contains [$self successors] $self]} {
 	    return 0
@@ -423,9 +423,9 @@
 			      [Untag $fragmentitems $cstype]]
 	    lappend newcsets $fragment
 	    $fragment persist
 
-	    if {[$fragment selfreferential]} {
+	    if {[$fragment loopcheck]} {
 		trouble fatal "[$fragment str] depends on itself"
 	    }
 	}