Diff
Not logged in

Differences From:

File tools/cvs2fossil/lib/c2f_prev.tcl part of check-in [deab4d035b] - Brought the variable names into alignment with the semantics, now again naming what is stored in them. by aku on 2007-11-29 07:36:27. [view]

To:

File tools/cvs2fossil/lib/c2f_prev.tcl part of check-in [39e19c0cf3] - Simplified some code dealing with the item -> changeset map, using the changed semantics (1:n -> 1:1). by aku on 2007-11-29 07:41:48. [view]

@@ -90,12 +90,9 @@
 	# NOTE / FUTURE: Possible bottleneck.
 	array set tmp {}
 	foreach {rev children} [$self nextmap] {
 	    foreach child $children {
-		# 8.5 lappend tmp($rev) {*}$myitemmap($child)
-		foreach cset $myitemmap($child) {
-		    lappend tmp($rev) $cset
-		}
+		lappend tmp($rev) $myitemmap($child)
 	    }
 	    set tmp($rev) [lsort -unique $tmp($rev)]
 	}
 	return [array get tmp]
@@ -106,12 +103,9 @@
 	# NOTE / FUTURE: Possible bottleneck.
 	set csets {}
 	foreach {_ children} [$self nextmap] {
 	    foreach child $children {
-		# 8.5 lappend csets {*}$myitemmap($child)
-		foreach cset $myitemmap($child) {
-		    lappend csets $cset
-		}
+		lappend csets $myitemmap($child)
 	    }
 	}
 	return [lsort -unique $csets]
     }
@@ -121,12 +115,9 @@
 	# NOTE / FUTURE: Possible bottleneck.
 	array set tmp {}
 	foreach {rev children} [$self premap] {
 	    foreach child $children {
-		# 8.5 lappend tmp($rev) {*}$myitemmap($child)
-		foreach cset $myitemmap($child) {
-		    lappend tmp($rev) $cset
-		}
+		lappend tmp($rev) $myitemmap($child)
 	    }
 	    set tmp($rev) [lsort -unique $tmp($rev)]
 	}
 	return [array get tmp]