Check-in [338854a61a]
Not logged in
Overview

SHA1 Hash:338854a61ad1f3b9e69d722b3d487cd07461bd0f
Date: 2007-10-10 04:23:22
User: aku
Comment:API tweak rcs parser, definition of symbols, call through the callback once per symbol instead of once for the whole set.
Timelines: ancestors | descendants | both | trunk
Other Links: files | ZIP archive | manifest

Tags And Properties
Changes
[hide diffs]

Modified tools/cvs2fossil/lib/c2f_file.tcl from [79e054b90e] to [4bd5111a52].

@@ -42,21 +42,21 @@
     method admindone {} {}
 
     method sethead            {h} {}
     method setprincipalbranch {b} {}
 
-    method setsymbols {dict} {}
-    method setcomment {c}    {}
-    method setdesc    {d}    {}
+    method deftag     {s r} {}
+    method setcomment {c}   {}
+    method setdesc    {d}   {}
 
     method def    {rev date author state next branches} {}
     method extend {rev commitmsg deltarange} {}
 
     #method begin {} {puts begin}
     #method sethead {h} {puts head=$h}
     #method setprincipalbranch {b} {puts pb=$b}
-    #method setsymbols {dict} {puts symbols=$dict}
+    #method deftag {s r} {puts $s=$r }
     #method setcomment {c} {puts comment=$c}
     #method admindone {} {puts admindone}
     #method def {rev date author state next branches} {puts "def $rev $date $author $state $next $branches"}
     #method setdesc {d} {puts desc=$d}
     #method extend {rev commitmsg deltarange} {puts "extend $commitmsg $deltarange"}
@@ -83,14 +83,12 @@
     method setprincipalbranch {b} {
 	set myprincipal $b
 	return
     }
 
-    method setsymbols {dict} {
-	# Slice symbols into branches and tags, canonical numbers ...
-array set _ $dict
-parray _
+    method deftag {symbol rev} {
+	# Slice symbols into branches and tags, canonical numbers ...
     }
 
     method setcomment {c} {# ignore}
     method setdesc    {d} {# ignore}
 

Modified tools/cvs2fossil/lib/rcsparser.tcl from [6dff67402b] to [4078955940].

@@ -74,20 +74,16 @@
 	Semicolon
 	return
     }
 
     proc Symbols {} {
-	set d {}
 	RequiredLiteral symbols
 	while {[Ident -> symbol]} {
 	    RequiredNumber -> rev
-	    # TODO: distinguish branch/tag symbols, transform revision
-	    # numbers into canonical form.
-	    lappend d $symbol $rev
+	    Call deftag $symbol $rev
 	}
 	Semicolon
-	Call setsymbols $d
 	return
     }
 
     proc Locks {} {
 	# Not saving locks.